Re: [PATCH] swsusp in 2.4.19-pre8-ac5

Le 28 Mai, Pavel Machek a écrit :
>> > What's the point of all those PRINTS -> __prints changes? I do not
>> > like additional abstractions on the top of printk(). Are they really
>> > neccessary?
>> 
>> Actually I tried to make the process prettier using a dedicated console.
>> The PRINT are for debugging, _print for the dedicated console (can be
>> deactivated using SUSPEND_CONSOLE) and __print are always written
>> (errors messages). The PRINTS PRINTR macros were used to separate
>> suspend and resume machine. It's not necessary but isn't that nicer when
>> you suspend ?
> 
> Are not "Suspend : " and "Resume : " superfluous if you have dedicated
> console, anyway?
> 
> Why don't you use generic printk() for messages that are printed, always?

OK, ok, I'll get back to more classic printing ;-) I'll clean it this
week-end.

> 
>> What about the CONFIG_SMP restriction ? Is it still pertinent ?
> 
> Yes, I'm afraid. If someone wants to donate me SMP pentium, I might
> try to debug that ;-).

I have one but that's an operational server, no chance to have a test on
it :-(

--
Florent Chabaud
http://www.ssi.gouv.fr | http://fchabaud.free.fr