Re: [PATCH] 2/3 Quota changes ported to 2.5.18

Martin Dalecki (dalecki@evision-ventures.com)
Wed, 29 May 2002 15:55:28 +0200


Jan Kara wrote:
> This second patch changes sysctl interface to use reasonable names in
> /proc/sys/fs/quota/
>
> Honza
>

Please note that the _dquots suffix for the alocated and
free entires of struct dqstats is:

1. Entierly redundant. (dqstats.allocated counts dquots what else?)

2. Orthogonal to the leak of it for the other fields.

static inline void put_inuse(struct dquot *dquot)
@@ -238,12 +238,12 @@
/* We add to the back of inuse list so we don't have to restart
* when traversing this list and we block */
list_add(&dquot->dq_inuse, inuse_list.prev);
-
++dqstats_array[DQSTATS_ALLOCATED];
+
dqstats.allocated_dquots++;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/