Re: [rfc,patch] breaking up sched.h

Russell King (rmk@arm.linux.org.uk)
Fri, 24 May 2002 21:52:49 +0100

On Fri, May 24, 2002 at 10:34:04PM +0200, Tim Schmielau wrote:
> While the latter three are probably better hosted in
> <linux/capability.h>, I'm unsure where to move the former two.
> <linux/irq.h> seems quite natural, but it starts with a comment
>
> /*
> * Please do not include this file in generic code. There is currently
> * no requirement for any architecture to implement anything held
> * within this file.
> *
> * Thanks. --rmk
> */
>
> so that seems to be no-go. Any alternative suggestions?

The problem with linux/irq.h is that it makes many assumptions about the
per-architecture irq code. If anyone needs to include it (in its current
form), then they're accessing architecture private data that may or may
not be present.

Maybe the correct thing would be to move linux/irq.h to linux/hw_irq.h
(so it matches asm/hw_irq.h) and move request_irq() and friends into a
new linux/irq.h

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/