Re: [PATCH] 2.5.17 IDE 67

[Tom Rini]

On Thu, May 23, 2002 at 08:08:40AM +0200, Martin Dalecki wrote:
> Uz.ytkownik Tom Rini napisa?:
> >On Wed, May 22, 2002 at 06:40:14PM +0200, Martin Dalecki wrote:
> >
> >>Uz.ytkownik Tom Rini napisa?:
> >>
> >>>And when the PPC4xx drivers are ready to be submitted we'll need to add
> >>>in __powerpc__ tests too.  Can't we just keep CONFIG_DMA_NONPCI for now?
> >>
> >>Plese feel free to add them when and where they are needed.
> >>It's no problem to clean this all up
> >>then again if a true usage pattern emerges.
> >>And I have no problem with patches toching "core" driver stuff as long
> >>as the changes are justified I will integrate them with pleasure at time.
> >
> >
> >Okay. :)
> >
> >BTW, maybe it's part of the great IDE rewrite and all, but the
> >CONFIG_DMA_NONPCI part of drivers/ide/ide.c didn't get a __CRIS__ added
> >back in.
> 
> Please look at ide-features.c there is should be there.

Er, you've lost me.  The call to ide_release_dma(ch) used to be guarded
by (CONFIG_BLK_DEV_IDEDMA) && !CONFIG_DMA_NONPCI) but is now just
guarded by CONFIG_BLK_DEV_IDEDMA.  Am I missing something (should all
drivers be implementing ide_release_dma()?)

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/