Re: Quota patches

[Jan Kara]

> > On Thu, May 23, 2002 at 09:30:10AM +1000, Nathan Scott wrote:
> > > ... but that should just about do the trick I think.
> > 
> > How does the patch below look Jan?
> 
> Doesn't let me select both ?
  Yes. Only one of compatible interfaces is allowed. The reason is
mainly due to QUOTAON. Both V1 and V2 interfaces used Q_QUOTAON
to turn quotas on (looking back I admit it was stupid but it happened).
So now we would have to recognize which quota file was actually given
to us and turn on proper quota format - and I dislike such magic in
kernel.. especially when it's not needed. When user has really old
quota tools (<=2.00) he will turn on V1 interface. If he has newer tools
(<3.05) he has to decide depending on format he wants to use... 3.05
and newer don't use this interface. Actually the easiest is always to
upgrade quota tools :) and this compatible interface mess is there
mainly due to possibility of backport into 2.4 kernels...
  
> > +if [ "$CONFIG_QUOTA" = "y" ]; then
> > +   define_bool CONFIG_QUOTACTL y
> > +   if [ "$CONFIG_QIFACE_COMPAT" = "y" ]; then
> > +       choice '    Compatible quota interfaces' \
> > +		"Original	CONFIG_QIFACE_V1 \
> > +		 VFSv0		CONFIG_QIFACE_V2" Original
> > +   fi
> >  fi

								Honza
-- 
Jan Kara <[e-mail]>
SuSE CR Labs