Re: [PATCH] SLC82C105 IDE driver: missing __init

Andrey Panin (pazke@orbita1.ru)
Wed, 22 May 2002 18:09:38 +0400


--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2002 at 02:10:06PM +0100, Alan Cox wrote:
> > slc82c105_bridge_revision() functions lacks __init modifier.
> > Attached patch (against 2.5.17) fixes it.
> > Compiles, but untested. Please consider applying.
>=20
> I wouldnt get too carried away with these. Once the IDE core is clean
> enough to allow hot plugging of IDE interfaces those __init's are all goi=
ng
> to need changing anyway

Then we'll grep and change them to __devinit.=20
But missing __init can't be changed :))

> (and yes you can get hot pluggable IDE setups already - the mobility stuff
> for example has a case with a PCI split bridge, 3 or 4 PCI slots and
> connects to the cardbus on a laptop)

--=20
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
--4Ckj6UjgE2iN1+kY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE866aiBm4rlNOo3YgRAgLiAJ4khTJzSnk2hk7Nnn/pofNuDSbX+ACgkQTX
/rtdFTeZwPwYsERjz5QhU0M=
=OFYX
-----END PGP SIGNATURE-----

--4Ckj6UjgE2iN1+kY--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/