Re: [PATCH] SLC82C105 IDE driver: missing __init

[Martin Dalecki]

Uz.ytkownik Russell King napisa?:
> On Wed, May 22, 2002 at 01:16:48PM +0400, Andrey Panin wrote:
> 
>>slc82c105_bridge_revision() functions lacks __init modifier.
>>Attached patch (against 2.5.17) fixes it.
>>Compiles, but untested. Please consider applying.
> 
> 
> I'm surprised it compiles. 

I'm not :-). I wouldn't be even surprised if it works by accident...

> I've got a rather major update to it here,
> but I need to find time to pull it out of the ARM patch, and I need IDE
> to settle down a bit so the two are actually in sync with each other.
> (Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm
> waiting for the fix to emerge, which I think is in 2.5.17, but the TLB

It should indeed be all in place right now. Other then this: If you feel like
something in the generic code has to be changed - don't hessitate just
do it. We can always sort it out.

> stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or
> test anything on 2.5 currently.)

Just to make it clean - this time it was not me ;-).

> 
> Too many things to do... too many problems to solve... too many patches
> to look at... too much email... not enough hours in the day... not enough
> fast machines to build kernels on... not enough rmk clones to run kernel
> tests... 8)