Not quite:
copy_from_user(xxx);
Is my suggestion. No error return.
> So a lot of people didn't get it? Arnaldo seems to have fixed a lot of
> them already
Yeah, thanks to my kernel audit. But I won't be auditing all 5,500
every release (I promised Alan I'd do 2.4 though: I'm waiting for the
next Marcelo kernel).
> and maybe you who apparently care can add _documentation_,
> but the fact is that there is no reason to make a less powerful interface.
It's been documented in the kernel docs. It's also in the device
driver book. And people still get it wrong because it's "special".
Please please please, Linus: to me this is like the min & max macros:
you didn't want a programmer trap in there, but everyone else
disagreed. If there's any sane way we can get rid of this trap (which
has shown to cause real bugs), I would weigh it very carefully.
Rusty.
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/