Re: AUDIT of 2.5.15 copy_to/from_user

[Arnaldo Carvalho de Melo]

Em Sun, May 19, 2002 at 02:18:53PM +1000, Rusty Russell escreveu:
> The following uses seem to be incorrect: copy_from_user and
> copy_to_user return the number of bytes NOT copied on failure, not
> -EFAULT.
> 
> You can CC: fixups to trivial at rustcorp.com.au.
> 
> (I didn't look for cases where the Torvalds/McVoy philosophy says we
> should be returning a partial result on EFAULT: that's more complex).
> 
> Thanks,
> Rusty.
> ================
> Some cases are endemic: whole subsystems or drivers where the author
> obviously thought copy_from_user follows the kernel conventions:

> sound/pci/*.c

Heads up: I'm fixing now the sound/pci ones...

- Arnaldo