[PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection

Luca Barbieri (ldb@ldb.ods.org)
11 May 2002 21:19:31 +0200


--=-9ZyLQKsRiOkTqgm5n1Vv
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

PPPoATM uses tasklet_disable() on a tasklet inside a struct and then
frees the struct, leaving a pointer to the freed tasklet inside tasklet
lists.
This patch replaces tasklet_disable() with tasklet_kill().

This bug is present in both 2.4.18 and 2.5.15 (and the patch applies to
both).

--- linux-old/net/atm/pppoatm.c Wed Apr 10 14:37:34 2002
+++ linux/net/atm/pppoatm.c Fri May 10 21:56:28 2002
@@ -125,7 +125,7 @@
pvcc =3D atmvcc_to_pvcc(atmvcc);
atmvcc->push =3D pvcc->old_push;
atmvcc->pop =3D pvcc->old_pop;
- tasklet_disable(&pvcc->wakeup_tasklet);
+ tasklet_kill(&pvcc->wakeup_tasklet);
ppp_unregister_channel(&pvcc->chan);
atmvcc->user_back =3D NULL;
kfree(pvcc);

--=-9ZyLQKsRiOkTqgm5n1Vv
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQA83W7Ddjkty3ft5+cRAuHJAJ9hgqFsR0U6ZY4sBf55XtWgzIbXPQCeJO9h
bw91pWe1Ln5XDEE/Y82AW/c=
=r8i7
-----END PGP SIGNATURE-----

--=-9ZyLQKsRiOkTqgm5n1Vv--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/