Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto]

On Fri, May 10, 2002 at 11:47:10AM +0200, Zwane Mwaikambo wrote:
> On Thu, 9 May 2002, A Guy Called Tyketto wrote:
> 
> > 
> >         IMHO, this isn't good. I just gave this a run with 2.5.15, and 
> > opl3_oss.c wasn't even touched during compile (either into the kernel or as a 
> > module); it's completely passed over. more than likely when inserted with 
> > modprobe, OSS emulation would fail from functions not being there. I haven't 
> > tried that yet, but this would be my guess..
> 
> OSS emulation? Or OPL3 OSS emulation?
> 

        This is for OPL3 OSS emulation. With your patch applied to 2.5.15, 
opl3_oss.c was not compiled at all, whether into the kernel, or as a module. 
Also, your patch for include/sound/opl3.h did not need to be applied as the 
#ifdef CONFIG_SND_OSSEMUL and #endif lines are already present sound the two 
variables listed.

                                                        BL.
-- 
Brad Littlejohn                         | Email:        [e-mail]
Unix Systems Administrator,             |           [e-mail]
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF