Re: [PATCH] remove 2TB block device limit

[Andrew Morton]

Anton Altaparmakov wrote:
> 
> ...
> >This code:
> >
> >         printk("%lu%s", some_sector, some_string);
> >
> >will work fine with 32-bit sector_t.  But with 64-bit sector_t it
> >will generate a warning at compile-time and an oops at runtime.
> >
> >The same problem applies to dma_addr_t.  Jeff, davem and I kicked
> >that around a while back and ended up deciding that although there
> >are a number of high-tech solutions, the dumb one was best:
> 
> Why not the even dumber one? Forget FMT_SECTOR_T and always use %Lu and
> typecast (unsigned long long)sector_t_variable in the printk.
> 

Agree.   The nice thing about the typecast is that you
can format the output with %06Lx, %9Ld, %Lo or whatever.
The FMT_SECTOR_T thing forces you to use the chosen formatting.

-