Re: [BK PATCH] PCI reorg fix

[Kai Germaschewski]

On Thu, 9 May 2002, Patrick Mochel wrote:

> Actually, the point _is_ to break everything. 
> 
> The fact that there are wrappers emulating old PCI behavior is the reason 
> the SCSI drivers don't use the 2.4 interface. If we provide wrappers for 
> alloc_consistent, they'll never change those, either. 

I surely can see your point there. However, new-style and old-style PCI 
init are conceptually different, and there's no easy way to emulate the 
old behavior on top of the new one. That is equivalent to saying that 
converting drivers is in many cases non-trivial. It's painful, and that's 
why it doesn't happen (or only slowly), unless you force people to do so.

However, the issue here is IMO different. Not having the wrappers only
means lots of trivial changes to the drivers, along the lines of

pci_set_dma_mask(pdev,) -> device_set_dma_mask(&pdev->dev,)

which is pointless IMO. Actually, as far as I understood things, the plan 
with the device tree is not expose it to drivers, but let them still
act on pci_dev / usb_dev / whatever, and only base the implementation of
struct pci_dev / usb/dev / ... on struct device.

So keeping these pci_* functions makes sense to me, only base the 
implementation on struct device.

--Kai