Re: [PATCH] parport irq sharing

[Jeff Garzik]

Zwane Mwaikambo wrote:

>--- linux-2.4.19-pre-ac/drivers/parport/parport_pc.c	Mon Apr  8 21:36:20 2002
>+++ linux-2.4.19-pre7-ac3/drivers/parport/parport_pc.c	Thu May  9 08:19:32 2002
>@@ -2355,7 +2355,7 @@
> 
> 	if (p->irq != PARPORT_IRQ_NONE) {
> 		if (request_irq (p->irq, parport_pc_interrupt,
>-				 0, p->name, p)) {
>+				 SA_SHIRQ, p->name, p)) {
> 			printk (KERN_WARNING "%s: irq %d in use, "
> 				"resorting to polled operation\n",
> 				p->name, p->irq);
>

I don't think you want to do this unconditionally... probably breaks 
older setups.

>
>--- linux-2.4.19-pre7-ac3/drivers/parport/parport_serial.c.orig	Sun May  5 14:24:36 2002
>+++ linux-2.4.19-pre7-ac3/drivers/parport/parport_serial.c	Thu May  9 09:46:58 2002
>@@ -249,7 +249,7 @@
> 	int success = 0;
> 
> 	if (cards[i].preinit_hook &&
>-	    cards[i].preinit_hook (dev, PARPORT_IRQ_NONE, PARPORT_DMA_NONE))
>+	    cards[i].preinit_hook (dev, dev->irq, PARPORT_DMA_NONE))
> 		return -ENODEV;
> 
> 	for (n = 0; n < cards[i].numports; n++) {
>

If parport_serial is 100% PCI (I'm too lazy to check), this should be ok...

    Jeff