Re: [PATCH] Possible SCSI (sr) mini-cleanup

Andreas Dilger (adilger@clusterfs.com)
Tue, 7 May 2002 16:02:35 -0600

On May 07, 2002 14:50 -0600, Thunder from the hill wrote:
> I don't see where the variable and the label have been used. Are they
> useful for anything? If they are, tell me please!

> @@ -723,8 +721,6 @@
> goto cleanup_cds;
> memset(sr_sizes, 0, sr_template.dev_max * sizeof(int));
> return 0;
> -cleanup_sizes:
> - kfree(sr_sizes);
> cleanup_cds:
> kfree(scsi_CDs);
> cleanup_devfs:

Note that you are also removing the "kfree(sr_sizes)" which is
definitely used...

Cheers, Andreas

--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/