Re: [PATCH] 2.5.14 IDE CD-ROM PIO mode

[Bartlomiej Zolnierkiewicz]

while we are here, I think that drivers shouldn't take
requests < hardsect_size, it should be handled by block layer

requests On Tue, 7 May 2002, Martin Dalecki wrote:

> Uz.ytkownik Christoph Hellwig napisa?:
> > On Tue, May 07, 2002 at 11:57:20AM +0200, Martin Dalecki wrote:
> >
> >>>@@ -962,7 +962,7 @@
> >>>
> >>> 	/* First, figure out if we need to bit-bucket
> >>> 	   any of the leading sectors. */
> >>>-	nskip = MIN(rq->current_nr_sectors - bio_sectors(rq->bio), sectors_to_transfer);
> >>>+	nskip = MIN((int)(rq->current_nr_sectors - bio_sectors(rq->bio)), sectors_to_transfer);
> >>
> >
> > What about a s/MIN/min/g in the idea driver to easily catch such bugs?
>
> Good idea partially already implemented :-).
> At least the generic code and the host chip driver code are alread
> switched to using those "chatch them" macros.