Re: [PATCH] drivers/net/depca.c tidyup

Dave Jones (davej@suse.de)
Mon, 6 May 2002 21:41:55 +0200


On Mon, May 06, 2002 at 08:01:01PM +0100, Peter Denison wrote:

> - offset = (offset + ALIGN) & ~ALIGN;
> + offset = ALIGN(offset, 8);
>
> And from include/linux/cache.h:
>
> #define ALIGN(x,a) (((x)+(a)-1)&~((a)-1))
>
> So, we're replacing (offset + 8 - 1) & ~(8-1) = (offset + 7) & ~7
> with (((offset)+(8)-1)&~((8)-1)) = ((offset+7)&~7)

Argh, I was looking at the definition in linkage.h
Cursed ctags.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/