Re: [PATCH 2.5.12] x86 Boot enhancements, boot params 1/11

[Eric W. Biederman]

Pavel Machek <[e-mail]> writes:

> Hi!
> 
> > > > #5  boot.heap
> > > > ============================================================
> > > > Modify video.S so that mode_list is also allocated from
> > > > the boot time heap.  This probably saves a little memory,
> > > > and makes a compiled in command line a sane thing to implement.
> > > 
> > > Do you see easy way to pass video mode used to kernel? S3 suspend support
> > > is going to need that..
> > 
> > Do you mean something other than the vga= command line option?
> > Which actually just sets a 16bit mode in the kernel parameter structure.
> 
> In case of vga=ask, it is kernel that gets number from the user,
> right?

Right.
 
> I'd need to know what mode was actually selected, so I can restore it
> after S3 resume.

I guess that works.  In this case it makes sense for the kernel to
store it in the same variable the video mode is specified in.  This
may require an extra store but it should be trivial to implement.

How are you handling the case of X and friends?  Are you making
certain to switch to kernel controlled vt?

My hunch is that this is a decent argument for real framebuffer drivers
in the kernel.  But that is a separate problem.

Eric