Re: [PATCH] 2.5.13 IDE 50

[Denis Vlasenko]

On 4 May 2002 21:53, Martin Dalecki wrote:
> Uz.ytkownik Tim Schmielau napisa?:
> >>- Fix wrong usage of time_after in ide.c. This should cure the drive
> >>seek
> >>   timeout problems some people where expierencing. This was clarified
> >>to me by
> >>   Bartek, who apparently checked whatever the actual code is consistent
> >>with the comments in front of it. Thank you Bartlomiej Zolnierkiewicz.
> >>
> >>   I think now that we should have time_past(xxx) in <linux/timer.h>.
> >
> > What would you suppose time_past(xxx) to do?
>
> Taking only a single parameter and telling whatever jiffies is bigger
> then it. Just that. Becouse if you grep for time_after or time_before
> you would realize immediately that nearly all of them take
> the variable jiffies as parameter.

Just in case it will be done: call it
jiffies_before(x) and jiffies_after(x), this sounds unambiguous IMHO.
--
vda