Re: [RFC] link_path_walk cleanup

Alexander Viro (viro@math.psu.edu)
Fri, 26 Apr 2002 13:26:45 -0400 (EDT)


On Fri, 26 Apr 2002, Andrew Morton wrote:

> Maneesh Soni wrote:
> >
> >..
> > +static inline int walk_one(struct nameidata *nd)
>
> This function is hundreds and hundreds of bytes of code. It has
> three call sites. Making it an inline is very inefficient!

Unfortunately, this is a very special case. This sucker is involved
in mutual recursion and extra frame on stack will be nasty for, say it,
sparc. Normally I would agree that something of that kind should not be
inlined, but...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/