Re: get_pid fixes against 2.4.19pre7

Russell King (rmk@arm.linux.org.uk)
Fri, 26 Apr 2002 12:53:47 +0100

On Fri, Apr 26, 2002 at 01:44:09PM +0200, Andrea Arcangeli wrote:
> + set_bit(p->pid, pid_bitmap);
> + set_bit(p->pgrp, pid_bitmap);
> + set_bit(p->tgid, pid_bitmap);
> + set_bit(p->session, pid_bitmap);

Since we're running under a lock, do we really need the guaranteed
atomic (and therefore expensive) set_bit(), or would __set_bit()
suffice?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/