Re: Linux 2.5.9-dj1

[Adrian Bunk]

Hi Dave,

it doesn't compile for me when CONFIG_SMP is set:

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.9/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6
-nostdinc -I /usr/lib/gcc-lib/i386-linux/2.95.4/include
-DKBUILD_BASENAME=sched  -fno-omit-frame-pointer -c -o sched.o sched.c
sched.c: In function `migration_thread':
sched.c:1685: `bind_cpu' undeclared (first use in this function)
sched.c:1685: (Each undeclared identifier is reported only once
sched.c:1685: for each function it appears in.)
sched.c: At top level:
sched.c:1681: warning: `migration_mask' defined but not used
make[2]: *** [sched.o] Error 1
make[2]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.9/kernel'

<--  snip  -->

It's the following part of the -dj1 patch (I've skipped the rest of the
sched.c changes):

--- linux-2.5.9/kernel/sched.c	Mon Apr 22 23:28:20 2002
+++ linux-2.5/kernel/sched.c	Tue Apr 23 11:43:38 2002
@@ -1672,7 +1678,9 @@
 	preempt_enable();
 }

-static int migration_thread(void * bind_cpu)
+static volatile unsigned long migration_mask;
+
+static int migration_thread(void * unused)
 {
 	int cpu = cpu_logical_map((int) (long) bind_cpu);
 	struct sched_param param = { sched_priority: 99 };

The problem seems to be that "bind_cpu" is renamed to "unused" but it is
used two lines later.

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox