Re: novice coding in /linux/net/ipv4/util.c From: DJ Barrow <[e-mail]>

[Andi Kleen]

DJ Barrow <[e-mail]> writes:

> This textbook peice of novice coding which has existed since 2.2.14.

Even earlier I think 

BTW do you call libresolv novice coding too ? 

> For those who can't spot the error, please note that this function is 
> returning a static string, excellent stuff if you are hoping to reuse the 
> same function like the following
> printk("%s %s\n",in_ntoa(addr1),in_ntoa(addr2));

That is why most of networking uses the NIPQUAD macro instead.

Best would be probably to convert the few remaining users of in_ntoa
to NIPQUAD and drop this function.

-Andi