Re: [PATCH] open files in kjounald

[Andreas Dilger]

On Apr 22, 2002  06:56 +0200, Ph. Marek wrote:
> On every mount of ext3 (and I suppose all journaling filesystems which use
> jbd, although I didn't test this) a new kjournald is created. All kjournald
> share the same file-information.
> 
> Before this patch it would accumulativly fetch open files from the calling
> process (normally mount); I verified this via (in bash)
> 	exec 30< /etc/services
> 	mount <partition> /mnt/tmp
> 	ps -aux | grep kjournald
> 	ls -la <pid of any kjournald>
> gives, among 0, 1 and 2
> 	30 -> /etc/services
> 
> This is really awful as you can't umount devfs (normally /dev/console is
> opened as from the start-scripts) and so / can't be umounted.
> 
> After applying this patch the open files were gone.

It looks OK to me, except that the patch is reversed.

> diff -ru linux/fs/jbd/journal.c linux.ori/fs/jbd/journal.c
> --- linux/fs/jbd/journal.c      Mon Apr 22 06:29:16 2002
> +++ linux.ori/fs/jbd/journal.c  Mon Apr 22 06:28:54 2002
> @@ -204,7 +204,6 @@
> 
>         lock_kernel();
>         daemonize();
> -       exit_files(current);
>         spin_lock_irq(&current->sigmask_lock);
>         sigfillset(&current->blocked);
>         recalc_sigpending(current);

Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/