Re: PowerPC Linux and PCI

[Paul Mackerras]

David S. Miller writes:

>    From: James L Peterson <[e-mail]>
>    Date: Fri, 19 Apr 2002 16:37:03 -0500
> 
>    if (pci_read_config_dword(temp, PCI_VENDOR_ID, &l))
>      return NULL;
>         ....
>      memcpy(dev, temp, sizeof(*dev));
>     dev->vendor = l & 0xffff;
>     dev->device = (l >> 16) & 0xffff;
>    
>    It seems to me this is incorrect for a big-endian machine
>    (like PowerPC).  If we read the two 16-bit parts out of the
>    first 32-bit part, we will end up with:
> 
> pci_read_config_dword should do the byte swapping on &l for
> the caller, fix your pci_{read,write}_config_*() arch implementation.

It does, that's why it all works. :)  James Peterson seems to have
missed this fact, hence his confusion.

Paul.