> If gcc optimizes the "cpu" into a register then fine but if not, it would
> be IMHO preferable to use this instead:
>
> BUG_ON(*(unsigned int *)info != smp_processor_id());
I favoured simplicity over optimisation here, as it's not a speed critical path.
> >(This contains some other bits too that I intend to push to Linus after
> > a pre1 appears)
> Why not push now considering 2.5.9 isn't out yet?
I've not pulled Linus' bk tree, but have noticed from the changelogs
that some changes went in already touching this file.
> Considering the current bitkeeper tree on bkbits does not compile on ia32
> UP at all by any close margin, the more fixes that go in now the better...
Erk.
> Releasing 2.5.9 in current state would not be too useful for people like me
> who experience the ide problems...
Agreed. I assumed the Linus just didn't add the "pre1" part to EXTRAVERSION
yet but, given that 2.5.8 doesn't compile for a lot of people, I can see
why pushing 2.5.9 out sooner would be a good thing.
I've been busy with x86-64 bits and other projects the last few days, I'll
continue pushing more bits from my tree (including the bluesmoke bits) to
Linus over the weekend.
Dave.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/