Re: 2.5.8 IDE oops (TCQ breakage?)

[Martin Dalecki]

Erik Andersen wrote:
> On Wed Apr 17, 2002 at 01:33:39PM +0200, Martin Dalecki wrote:
> 
>>Yes I see. However for now I will just concentrate on ide-cd.c and
>>await you to merge up with IDE 37 OK? (It should be easy this time :-).
> 
> 
> While working on ide-cd, I think the bad sector handling needs
> serious attention...  For example, I have a CD-ROM (a toddler
> game for windoz) that my 2 year old son scratched into
> non-functional oblivion.  I attempted to extract the contents in
> the hope of burning it to a new CD.  Using dd conv=noerror, it
> began ripping the content just fine -- till it hit the bad spot.
> Then it took like 12 hours to progress by an additional 10 MB...
> 
> Looking at the ide-cd code (since I used to maintain it years
> ago) it seems that on a bad sector, ide-cd retries ERROR_MAX (8)
> times.  But the low level ide driver is _also_ doing ERROR_MAX
> retries for each of those 8 retries from ide-cd....   Do we
> really need to retry 64 times when the drive told us clearly the
> _first_ time that it is an uncorrectable medium error?  
> 
> Perhaps something like this patch would make more sense?  With
> this patch is place, error handling is still awful, but at least
> a dd was able to make a bit of progress....  

Yeep you are entierly right. I will include your patch directly.