Re: [PATCH] Change "return EBLAH" to "return -EBLAH in drivers/*

[Itai Nahshon]

On Wednesday 17 April 2002 07:42 am, Anthony J. Breeds-Taurima wrote:
> --- linux-2.4.19-pre6.clean/drivers/net/plip.c  Mon Oct 22 16:05:31 2001
> +++ linux-2.4.19-pre6/drivers/net/plip.c        Wed Apr 17 11:08:35 2002
...
> -                       return ERROR;
> +                       return -ERROR;

At least the changes to plip.c are wrong.

ERROR is not an errno value:
	#define ERROR     2
and the return from this function is propgated to a test
                if (error != ERROR) { /* Timeout */
Which will go wrong with the suggested patch.

-- Itai