Re: [BK PATCH] USB device support for 2.5.8 (take 2)

[Linus Torvalds]

On Tue, 16 Apr 2002, Greg KH wrote:
>
> It's code to be a USB client device, not a USB host device, which is
> what we currently have.  It is used in embedded devices that run Linux,
> like the new Sharp device (can't remember the name right now...)

Ahhh.. A dim light goes on.

It would have made more sense (I think) to call it "usb/client" instead of
"usb/device", but maybe that's just because I didn't understand what the
thing was all about.

(Ask Davem some day about my irrational hang-ups about naming, and how I
sometimes like the same code if it's just named differently ;)

> Sorry.  I spend most of my time on this code just cleaning the format
> and removing build errors, instead of looking at the content :(
>
> I'll work on fixing all of the crap before submitting it again.

In this case, the only reason I started really looking at the content was
that I didn't know what it was even supposed to do and was confused about
the naming, so I started looked at a few files. Which didn't really make
me go understand what it did, but _did_ make me puke.

Maybe the rest of it is wonderfully beautiful code, and I was just unlucky
in my selection ;)

			Linus