Re: [RFC] Patch: aliasing bug in blockdev-in-pagecache?

Alexander Viro (viro@math.psu.edu)
Sun, 14 Apr 2002 08:59:15 -0400 (EDT)


On Sat, 13 Apr 2002, Stephen C. Tweedie wrote:

> To solve this, we really do need to have block_read_full_page() test
> the uptodate state under protection of the buffer_head lock. We
> already go through 3 stages in block_read_full_page(): gather the
> buffers needing IO, then lock them, then submit the IO. To be safe,
> we need a final test for buffer_uptodate() *after* we have locked the
> required buffers.

Ouch.

I suspect that correct fix is to do that test in submit_bh() itself
(and remove it from ll_rw_block()). IMO it's cleaner than messing
with all callers out there... Linus?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/