Re: [PATCH] remove compiler.h from mmap.c

[Paul Mackerras]

Rik van Riel writes:

> Absolutely agreed, but likely/unlikely is such low-level
> stuff that it shouldn't be included directly into .c files,
> IMHO.

mm/mmap.c uses unlikely (line 570).  Therefore it should include
compiler.h itself IMHO, not rely on some other header to include it.
I think that each .c and .h file should include the headers that
define the things it uses, but should not have to include headers just
to define things that subsequent headers use.

Regards,
Paul.