Re: [PATCH] remove compiler.h from mmap.c

Rik van Riel (riel@conectiva.com.br)
Thu, 11 Apr 2002 14:58:07 -0300 (BRT)

On Thu, 11 Apr 2002, Tom Rini wrote:
> On Thu, Apr 11, 2002 at 02:37:23PM -0300, Rik van Riel wrote:
>
> > compiler.h is included via other include files now and its
> > #include has been removed from most C files, this patch
> > finishes the job for mm/*
>
> What #include file is mm/mmap.c getting <linux/compiler.h> from now?

slab.h -> mm.h -> sched.h -> kernel.h -> compiler.h

> Hiding (or relying on indirect) #includes isn't always a good thing...

Absolutely agreed, but likely/unlikely is such low-level
stuff that it shouldn't be included directly into .c files,
IMHO.

regards,

Rik

-- 
Will hack the VM for food.


http://www.surriel.com/		http://distro.conectiva.com/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/