Re: [patch-2.5.8-pre] swapinfo accounting

[Mike Fedyk]

On Wed, Apr 10, 2002 at 06:20:55PM -0700, Randy.Dunlap wrote:
> Anyway, here is the patch that makes it better.
> Not perfect, due to possibility of bad blocks, but better
> than it was.   Comments?
> 
> 
> --- linux-258-pre2/mm/swapfile.c.SI	Wed Apr 10 17:50:34 2002
> +++ linux-258-pre2/mm/swapfile.c	Wed Apr 10 18:09:46 2002
> @@ -1107,8 +1107,8 @@
>  			}
>  		}
>  	}
> -	val->freeswap = nr_swap_pages + nr_to_be_unused;
> -	val->totalswap = total_swap_pages + nr_to_be_unused;
> +	val->freeswap = nr_swap_pages;
> +	val->totalswap = total_swap_pages;
>  	swap_list_unlock();
>  }

Shouldn't that be s/+/-/ instead?  If this is badblocks accounting, it
should probably be subtracted instead of added.