Re: Linux-2.5.8-pre1

[Tim Schmielau]

On Thu, 4 Apr 2002, Martin Dalecki wrote:

> By just reading the patch I have came across the following code:
> 
> diff -Nru a/arch/cris/drivers/ethernet.c b/arch/cris/drivers/ethernet.c
> --- a/arch/cris/drivers/ethernet.c	Wed Apr  3 17:11:15 2002
> +++ b/arch/cris/drivers/ethernet.c	Wed Apr  3 17:11:15 2002
> ......
> 
> @@ -1313,7 +1313,7 @@
>   static void
>   e100_clear_network_leds(unsigned long dummy)
>   {
> - 
> if (led_active && jiffies > led_next_time) {
> + 
> if (led_active && jiffies > time_after(jiffies, led_next_time)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This should almost certainly be instead:
> 
> + 
> if (led_active && time_after(jiffies, led_next_time)) {
> !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Yes, my mistake. Please correct.

Tim (wondering how this patch made it into 2.5.8-pre1)