Re: Linux 2.5.7-dj3

[Adrian Bunk]

Hi Dave,

I got the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.7/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6   -DKBUILD_BASENAME=pdc4030  -c -o pdc4030.o pdc4030.c
pdc4030.c: In function `promise_multwrite':
pdc4030.c:447: warning: passing arg 2 of `bio_kmap_irq' makes pointer from
integer without a cast
pdc4030.c: In function `promise_rw_disk':
pdc4030.c:664: structure has no member named `channel'
make[3]: *** [pdc4030.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.7/drivers/ide'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.7/drivers/ide'
make[1]: *** [_subdir_ide] Error 2
make[1]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.7/drivers'
make: *** [_dir_drivers] Error 2

<--  snip  -->

The code that failed is the following part of -dj3 that s not in
2.5.8-pre1:

--- linux-2.5.7/drivers/ide/pdc4030.c	Mon Mar 18 20:37:08 2002
+++ linux-2.5/drivers/ide/pdc4030.c	Thu Apr  4 04:19:50 2002
@@ -645,6 +656,13 @@

 	memset(&taskfile, 0, sizeof(struct hd_drive_task_hdr));

+	/* The four drives on the two logical (one physical) interfaces
+	   are distinguished by writing the drive number (0-3) to the
+	   Feature register.
+	   FIXME: Is promise_selectproc now redundant??
+	*/
+	taskfile.feature	= (HWIF(drive)->channel << 1) + drive->select.b.unit;
+
 	taskfile.sector_count	= rq->nr_sectors;
 	taskfile.sector_number	= block;
 	taskfile.low_cylinder	= (block>>=8);

cu
Adrian