Re: [PATCH] x86 Boot enhancements, boot protocol 2.04 7/9

[Eric W. Biederman]

Tom Rini <[e-mail]> writes:

> On Wed, Apr 03, 2002 at 09:41:55AM -0700, Eric W. Biederman wrote:
> 
> > In imitation of the arm and ppc ports a CONFIG_CMDLINE option is also
> > implemented.
> 
> Just wondering, why didn't you do it with a
> CONFIG_CMDLINE_BOOL/CONFIG_CMDLINE set of options?  The way you did it,
> I _think_ you can't actually get a help msg from 'config' or
> 'oldconfig', you'll just set the commandline to '?'.

I just tested it and oldconfig at least works.  The overhead is exactly
one byte.
 
> Also, on current PPC, if we have a compiled-in commandline we put it in
> arch/ppc/kernel/setup.c and allow it to be overridden.  This even makes
> it semi-useful outside of the self-containted {b,}zImage situation.

I currently allow a compiled in command line to be appended to.  lilo also
does this when you specify a command line, and to my knowledge all boot options
prefer the last value specified so that should be good enough.  As the decision
happens in C code it isn't to hard to change either way.

Eric