Re: 3c59x.c - kernel message explosion (fwd)

Jeff Garzik (jgarzik@mandrakesoft.com)
Wed, 03 Apr 2002 18:49:44 -0500


Denny Gudea wrote:
> i believe the problem resides when it tests for the debug level:
>
> if (vortex_debug > 2
> || (tx_status != 0x88 && vortex_debug > 0)) {
>
> the || operator should be a && because we only want to print the error
> message if debug is greater than 2 and the transmit status is not what it
> should be.

the test looks ok... it prints if the status is not what it should be,
if vortex_debug is 1 or 2, and unconditionally prints the status if
vortex_debug is 3 or greater.

What is your vortex_debug setting?

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/