Re: [PATCH 2.5.5] do export vmalloc_to_page to modules...

[Gerd Knorr]

Alan Cox wrote:
> > The fact that the code was back-ported from 2.5.x and that the _GPL still 
> > is there too is just a mistake, partly because I've not gotten any updates 
> > from Ingo..
>  
>  So Linus is allowed to arbitarily export other peoples contributions ? I
>  think we need to clear this one up and understand what people think the
>  actual rules are around here. As I understand it the original code was
>  a) extracted from bttv and is code which I and DaveM partly wrote
>  b) was submitted by Gerd who did the extra work and kept it as _GPL when he 
>     first exported it. (in 2.4 its relevant to expose it as we have the V4L1
>     not V4L2 interface)

No.

I've only submitted the 2.4.x backport to Marcelo, and the only reason
I've export it as _GPL there is that it is _GPL in 2.5.x.  Having that
symbol without _GPL in 2.4 and with _GPL in 2.5 would be very bad style
and would upset people who start using that function in 2.4 and notice
later on that it is exported more strict in 2.5 ...

I'll happily submit a patch to Marcelo to remove the _GPL once it is
gone in Linus 2.5 tree.

The 2.5.x code (which I grabbed for the backport) was submitted by Ingo
and updated by Linus says my BK tree changelog.  Ingo obviously did
*not* a simple cut&paste of DaveM's code from bttv.  The 2.5.x
vmalloc_to_page() function handles pte-highmem and preemtable kernels,
that code was never in bttv.

>  Nobody seems to have remembered to ask permission around here

Ingo is happy with removing _GPL, Linus too, where exactly is the
problem?

  Gerd

-- 
#include </dev/tty>