Re: [PATCH] bitops cleanup 3/4

[Richard Gooch]

Rusty Russell writes:
> Linus, please apply (no object code changes).
> 
> This changes everything arch specific PPC and i386 which should have
> been unsigned long (it doesn't *matter*, but bad habits get copied).
> 
> I left the devfs ones for Richard to submit separately, since they
> actually change the resulting code.

??? But you didn't leave the devfs ones alone: your patch changes a
devfs file:

> diff -urN -I \$.*\$ --exclude TAGS -X /home/rusty/current-dontdiff --minimal linux-2.5.7-pre1/include/linux/devfs_fs_kernel.h working-2.5.7-pre1-bitops/include/linux/devfs_fs_kernel.h
> --- linux-2.5.7-pre1/include/linux/devfs_fs_kernel.h	Fri Mar 15 15:37:39 2002
> +++ working-2.5.7-pre1-bitops/include/linux/devfs_fs_kernel.h	Sat Mar 16 13:54:53 2002
> @@ -54,7 +54,7 @@
>      unsigned char sem_initialised;
>      unsigned int num_free;          /*  Num free in bits       */
>      unsigned int length;            /*  Array length in bytes  */
> -    __u32 *bits;
> +    unsigned long *bits;
>      struct semaphore semaphore;
>  };
>  

Anyway, I hope to have a devfs patch for 2.5.x ready before next
week. I've got some other changes in the works, as well as the bitops
changes, which I've already submitted for 2.4.x.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]