Re: 2.4.19pre5aa1 and splitted vm-33

Christoph Hellwig (hch@infradead.org)
Sun, 31 Mar 2002 19:10:59 +0100


On Sun, Mar 31, 2002 at 04:48:15PM +0200, Andrea Arcangeli wrote:
> Only in 2.4.19pre5aa1: 00_o_direct-open-check-1
>
> Move the check for O_DIRECT support into the open(2) syscall. Make
> sense, also the xine folks asked for that feature to cleanup
> some userspace. Patch from Chuck Lever.

This breaks XFS O_DIRECT handling, which is not implemented through ->direct_IO.
For the open case putting the check into generic_file_open sounds good to me,
but I have no idea on how to handle the fcntl case - which btw already allocates
kiobufs even if XFS doesn't need them..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/