Re: Linux 2.4.19-pre5: bad config

Russell King (rmk@arm.linux.org.uk)
Sat, 30 Mar 2002 09:06:02 +0000

On Sat, Mar 30, 2002 at 11:11:12AM +1100, Eyal Lebedinsky wrote:
> In drivers/mtd/maps/Config.in CONFIG_ARM is used in the condition, so
> maybe a better patch will be to do the same here? I leave this to the
> experts.

I have a patch for this.

> -dep_tristate ' SA1100 support' CONFIG_PCMCIA_SA1100 $CONFIG_ARCH_SA1100 $CONFIG_PCMCIA
> +if [ "$CONFIG_ARCH_SA1100" = "y" ]; then
> + dep_tristate ' SA1100 support' CONFIG_PCMCIA_SA1100 $CONFIG_PCMCIA
> +fi

It's basically to wrap it in an CONFIG_ARM and leave the SA1100 dependency.
Why? There are other ARM PCMCIA drivers, and rather have a mass of if
statements, I'd rather see dep_*

I'll dig out the patch later today.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/