Re: [PATCH] generic show_stack facility

Andrew Morton (akpm@zip.com.au)
Fri, 29 Mar 2002 10:41:11 -0800


Christoph Hellwig wrote:
>
> On Fri, Mar 29, 2002 at 09:36:26AM -0800, Andrew Morton wrote:
> > Here's the diff. Comments?
>
> I don't see who having to independand declaration in the same kernel
> image are supposed to work..

It goes in lib/lib.a. The linker will only pick up
the default version if the architecture doesn't
have its own dump_stack().

bust_spinlocks() has worked that way for quite some time.

> I think you really want some HAVE_ARCH_SHOW_STACK define to disable
> the generic version..

Yup. But it's nice to be able to slot the default version
into lib.a. In the bust_spinlocks case, architectures only
need to implement a version if they have special needs.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/