Re: [PATCH] 2.4.19-pre4 ide-probe

[Andre Hedrick]

Looking into it today.

On Tue, 26 Mar 2002, Jeff Chua wrote:

> On Fri, 22 Mar 2002, Andre Hedrick wrote:
> 
> > This is the bases of the codes origin.
> 
> So, should it be removed then? If not, how can you get rid of the
> ide_xlate_1024 unknown symbol?
> 
> Jeff.
> 
> 
> 
> >
> > Comments?
> >
> > Andre Hedrick
> > LAD Storage Consulting Group
> >
> > On Thu, 21 Mar 2002, Jeff Chua wrote:
> >
> > >
> > > Marcelo, Andre,
> > >
> > > Someone apparently added the "hook", but it was never used in the kernel,
> > >
> > > What is ide_xlate_1024 referring to?
> > >
> > > Jeff
> > >
> > > ---------- Forwarded message ----------
> > > Date: Thu, 14 Mar 2002 11:22:27 +0800 (SGT)
> > > From: Jeff Chua <[e-mail]>
> > > To: Linux Kernel <[e-mail]>,
> > >      Marcelo Tosatti <[e-mail]>
> > > Cc: Jeff Chua <[e-mail]>
> > > Subject: [PATCH] 2.4.19-pre3 ide_xlate_1024_hook ???
> > >
> > >
> > > It seems that the "ide_xlate_1024_hook" is redundant in
> > > ./drivers/ide/ide-probe.c
> > >
> > > It's not used anywhere by the kernel, and it caused "depmod" to fail
> > > with unknown ide_xlate_1024_hook symbol.
> > >
> > >
> > > Jeff
> > >
> > > Patch ...
> > >
> > > --- ./drivers/ide/ide-probe.c.org       Thu Mar 14 11:01:20 2002
> > > +++ ./drivers/ide/ide-probe.c   Thu Mar 14 11:03:16 2002
> > > @@ -987,7 +987,6 @@
> > >  }
> > >
> > >  #ifdef MODULE
> > > -extern int (*ide_xlate_1024_hook)(kdev_t, int, int, const char *);
> > >
> > >  int init_module (void)
> > >  {
> > > @@ -997,14 +996,12 @@
> > >                 ide_unregister(index);
> > >         ideprobe_init();
> > >         create_proc_ide_interfaces();
> > > -       ide_xlate_1024_hook = ide_xlate_1024;
> > >         return 0;
> > >  }
> > >
> > >  void cleanup_module (void)
> > >  {
> > >         ide_probe = NULL;
> > > -       ide_xlate_1024_hook = 0;
> > >  }
> > >  MODULE_LICENSE("GPL");
> > >  #endif /* MODULE */
> > >
> > >
> > >
> >
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [e-mail]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Andre Hedrick
LAD Storage Consulting Group