Re: [PATCH] 2.4.19 do_adjtimex parameter checking

[Ulrich Windl]

On 24 Mar 2002, at 5:14, Paul Gortmaker wrote:

> Okay then, the bug still stands, but you want a different fix really.
> The user that reported it to me was infact setting multiple bit
> combos, which you indicate as taboo (but currently allowed). So 
> when multiple bit combos are given, we can either do:
> 
> a) return -EINVAL if more than ADJ_OFFSET_SINGLESHOT is set
> b) clear/ignore any bits above and beyond ADJ_OFFSET_SINGLESHOT.
> 
> As you are a time guru, please indicate which is preferable and I will
> bounce Rusty an appropriate patch.

Thanks for the flowers,

my preference is EINVAL of course. Silently adjusting parameters is bad 
IMHO.

Regards,
Ulrich