Re: [patch 2.5] seq_file for /proc/partitions

[Alexander Viro]

On Sat, 23 Mar 2002 [e-mail] wrote:

> +static void *part_next(struct seq_file *part, void *v, loff_t *pos)
> +{
> +	++*pos;
> +	return part_start(part, pos);

Erm...  Actually that _is_ wrong - what you want is

	return ((struct gendisk)v)->next;

> +}

Reasons:
	a) just how many times do you want to grab that lock?
	b) why bother scanning the list from the very beginning each time?