Re: BUG: 2.4.18 & ALI15X3 DMA hang on boot

[Vojtech Pavlik]

On Sat, Mar 23, 2002 at 02:11:21PM +0100, Martin Dalecki wrote:
> John Langford wrote:
> > I went nuts with printk statements and managed to isolate the hang to
> > one particular line of code.  The final printk in this code fragment
> > never gets executed.  
> > 
> >                 } else if (m5229_revision >= 0xC3) {
> > 		        /*
> >                          * 1553/1535 (m1533, 0x79, bit 1)
> >                          */
> >                         printk("ata66_ali15x3           } else if (m5229_revisi\on >= 0xC3) {\n");
> >                         pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x02);
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> pci_write_config to isa_dev???? This looks at least suspicious.
> You may very well check whatever isa_dev is trully a PCI device
> handle or just some random IO base for ISA bus!

You may wanted to check yourself:

isa_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, NULL);

so the command is valid.

> >                 printk("ata66_ali15x3 endif\n");
> > 
> > Art, Dave, and Ben may or may not have the same problem.  It would be
> > interesting to know if they get a hang here.
> > 
> > Any ideas for fixing?
> 
> See above :-)

-- 
Vojtech Pavlik
SuSE Labs