Re: [PATCH] matroxfb_base.c - not a so little patch

[Petr Vandrovec]

On 22 Mar 02 at 16:47, Denis Zaitsev wrote:
> 
> The patch is against 2.5.5.  It seems that matroxfb_base.c is still
> the same since that time.  And I assume matroxfb_base.c with
> <if (var->bits_per_pixel == 4)> branch present, i.e. without my
> previous little fix.

Did you verified effects on generated code/data size? 

> +   for (p= &table[0].bpp; *p < bpp; p+= sizeof table[0]);
> +   var->red   .offset= *++p; var->red   .length= *++p;
> +   var->green .offset= *++p; var->green .length= *++p;
> +   var->blue  .offset= *++p; var->blue  .length= *++p;
> +   var->transp.offset= *++p; var->transp.length= *++p;

Please no. Access fields by their names, and do not assume anything
about padding.
                                                Petr Vandrovec
                                                [e-mail]