Re: Question about the ide related ioctl's BLK* in 2.5.7-pre1 kernel

Martin Dalecki (dalecki@evision-ventures.com)
Thu, 14 Mar 2002 13:51:49 +0100


Jeff Garzik wrote:
> Martin Dalecki wrote:
>
>> Andrew Morton wrote:
>>
>>> Roberto Nibali wrote:
>>>
>>>> What for are BLKRAGET, BLKFRAGET and BLKSECTGET still needed?
>>>
>>>
>>>
>>> They got collaterally damaged in the IDE "cleanup". The patch at
>>> http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.6/dallocbase-10-readahead.patch
>>>
>>> resurrects them.
>>
>>
>>
>> This is WRONG. What I did here was just removal of unused code.
>> They got obsoleted by the BIO infrastructure changes.
>
>
> Martin,
>
> Did Andrew really deserve that?
>
> Andrew's patch -implements- those ioctls.
>
> Can our new IDE maintainer please have a little bit more patience and
> respect to those who have been hacking the kernel actively for a while?
> Andrew certainly has earned our respect... calling changes wrong without
> reading them does not.

It was just a note on the who "broke them". However I welcome his
efforts to actually implement the functionality in a clean manner.
Still something unclear? I wish not?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/