Re: [bkpatch] Multiple threads in core dumps (was: Re: Thread

[Tachino Nobuhiro]

Hello,

I am now trying to implement gcore system call on linux and have a 
great interest in your patch.

At Sat, 09 Mar 2002 16:13:22 -0500,
Daniel Jacobowitz wrote:
> 
> Here it is, against 2.5.6-pre2 (linux-2.5).  I'll do a version for 2.4
> after it makes it into 2.5.
>
>
> I'm looking for feedback on this.  Particularly two things:

 One small feedback.
 If one of the threads sleeps with TASK_UNINTERRUPTIBLE, stop_all_threads()
 eats all CPU resources. I think following patch needed.

diff -ru linux-2.5-core.org/kernel/sched.c linux-2.5-core/kernel/sched.c
--- linux-2.5-core.org/kernel/sched.c	Mon Mar 11 19:08:00 2002
+++ linux-2.5-core/kernel/sched.c	Tue Mar 12 12:45:57 2002
@@ -763,6 +763,7 @@
 		if (all_stopped)
 			break;
 		read_unlock(&tasklist_lock);
+		set_current_state(TASK_UNINTERRUPTIBLE);
 		schedule_timeout(1);
 		read_lock(&tasklist_lock);
 	}