Re: 3c59x and cardbus

Andrew Morton (akpm@zip.com.au)
Tue, 26 Feb 2002 10:51:08 -0800


christophe barbé wrote:
>
> Ok I have found why.
> When I resinsert the card, the driver give it a new id (this driver
> supports multiple cards) and the option as I set it is only defined for
> the card #0. I would expect that the driver give the same id back.
>

hrm. OK, hotplugging and slot-positional module parameters weren't
designed to live together.

This should fix it for single cards. For multiple cards, you'll
have to make sure you eject them in reverse scan order :)

Index: drivers/net/3c59x.c
===================================================================
RCS file: /opt/cvs/lk/drivers/net/3c59x.c,v
retrieving revision 1.74.2.7
diff -u -r1.74.2.7 3c59x.c
--- drivers/net/3c59x.c 2002/02/13 21:03:03 1.74.2.7
+++ drivers/net/3c59x.c 2002/02/26 18:49:24
@@ -2898,6 +2898,9 @@
BUG();
}

+ if (vp->card_idx == vortex_cards_found)
+ vortex_cards_found--;
+
vp = dev->priv;

/* AKPM: FIXME: we should have

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/